Skip to content

[WIP] Status fetch #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 13, 2023
Merged

[WIP] Status fetch #1483

merged 4 commits into from
Jan 13, 2023

Conversation

alensiljak
Copy link
Contributor

@alensiljak alensiljak commented Dec 21, 2022

This Pull Request fixes/closes #1471.

It changes the following:

  • adds the Fetch command to the status window

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

Comments

This is a WIP. Looking for feedback. Adding the Fetch command to the window was easy. Now, the Fetch popup has been designed to fetch all. This is what the current version is doing, hence the warning for unused branch string. It is possible:

  • remove the branch string and keep fetch_all as the command
  • implement the branch fetching in fetch_popup

What would you suggest?

@extrawurst
Copy link
Collaborator

you can install cargo deny: https://github.com/EmbarkStudios/cargo-deny

@alensiljak
Copy link
Contributor Author

updated.

cargo deny check
advisories ok, bans ok, licenses ok, sources ok

@extrawurst extrawurst merged commit 1dc097e into gitui-org:master Jan 13, 2023
@alensiljak alensiljak deleted the status-fetch branch January 13, 2023 14:43
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this pull request Jun 4, 2024
* adding the command to Status view
* cleanup and fix warnings

Co-authored-by: extrawurst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch command in status tab for just the current branches remote
2 participants