-
-
Notifications
You must be signed in to change notification settings - Fork 608
Add command for tagging commit #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command for tagging commit #187
Conversation
@cruessler thanks for tackling this.
I would rely on git refusing an invalid tag. we have a reusable error message box for that already.
Not exactly sure what you mean? I would expect the same dialog we already use for the stash-name. edit: you can run - the currently failing - clippy checks locally by simply using |
@extrawurst Thanks for the feedback! I have incorporated it and am now able to locally tag commits. The revlog does not update, though, after a commit is tagged and I have found no way to change that. |
@cruessler I could help you more when you would push those changes you made :) edit: just checked, new tags were never picked up in the revlog, has nothing todo with your PR: #190 |
@cruessler as of #195 new tags will be refetched every 2s. when you add a tag you can also force a refetch (because we know a new one is gonna be there) in
|
e52ff1c
to
3bd9c51
Compare
@extrawurst I updated the branch with your feedback. I did not need to explicitly ask the |
@cruessler nice work! thank you! ❤️ |
Opened as a draft for getting early feedback.
Open questions:
repo.tag
or do you wantto rely on git refusing invalid tags?
Will close #103.