Skip to content

Add ssh sign feature #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add ssh sign feature #2023

wants to merge 1 commit into from

Conversation

yanganto
Copy link
Contributor

This Pull Request fixes #1149.

It changes the following:

  • add --ssh-key-path and --ssh-key-password for the ssh signing key
  • sign a commit when the ssh key is set

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@extrawurst
Copy link
Collaborator

i am working through a bunch of piled up issues here this week and come back to you @yanganto

@extrawurst
Copy link
Collaborator

@yanganto based on your last comment in the ref issue:

There are things we need to think about before completing the PR. I have checked this signed commit with the ssh key will show verified tag in GitHub.

There will be a duplicate syn crate in the dependency, for 1.0 and 2.0

that should be fixed once you update to current master

There will be a warning with the crate for RSA SSH key, but it breaks the current CI.

not sure what that means. can you fix the other ci compiler/clippy issues so that we can see that?

The key path is passed from options, and we do not need additional TUI on it, because users do not change the signing key for different commits.

I am fine with no additional TUI for it in the first iteration. but I think we need some slightly simpler UX for providing this. Is there a standard way how this key is provided for example to git (the normal cli)? maybe env variables? or is it also purely via cli args?

@yanganto
Copy link
Contributor Author

yanganto commented Feb 12, 2024

@yanganto based on your last comment in the ref issue:

There are things we need to think about before completing the PR. I have checked this signed commit with the ssh key will show verified tag in GitHub.
There will be a duplicate syn crate in the dependency, for 1.0 and 2.0

that should be fixed once you update to current master

Great!

There will be a warning with the crate for RSA SSH key, but it breaks the current CI.

not sure what that means. can you fix the other ci compiler/clippy issues so that we can see that?

Just hard to find another crate with the same function but using syn2. This is the same issue as the previous point.

The key path is passed from options, and we do not need additional TUI on it, because users do not change the signing key for different commits.

I am fine with no additional TUI for it in the first iteration. but I think we need some slightly simpler UX for providing this. Is there a standard way how this key is provided for example to git (the normal cli)? maybe env variables? or is it also purely via cli args?

I will happy to use GITUI_SSH_KEY_PATH and GITUI_SSH_KEY_PASSWORD for the first iteration and moving forward from this.

@yanganto
Copy link
Contributor Author

This feature will work at #2047.

@yanganto yanganto closed this Feb 13, 2024
@yanganto yanganto mentioned this pull request Apr 10, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign git commits with SSH keys
2 participants