Skip to content

Bump tui: 0.9 -> 0.12 #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 8, 2020
Merged

Bump tui: 0.9 -> 0.12 #289

merged 11 commits into from
Oct 8, 2020

Conversation

WizardOhio24
Copy link
Contributor

Closes #205, Closes #285

Notable changes:

  • Text -> Span
  • Paragraph was changed such that '\n' no longer creates a new line, rather Spans (Vec<Span>) has to be used where each Spans would be a new line

(I've tried to fix all the paragraphs but if there is a paragraph which shows its elements horizontally rather than vertically, this PR is most likely the cause)

tui::widgets::Paragraph.title_style() is deprecated and command::CommandInfo.print() is no longer used, should these be fixed in this PR? (They're easy fixes)
Also, the test for line endings in DiffComponent was removed as it no longer applies.

@WizardOhio24
Copy link
Contributor Author

There's now no more clippy warnings caused by upgrading tui to 0.11. The deprecations warnings have been fixed and command.print() has been removed.

@extrawurst
Copy link
Collaborator

@WizardOhio24 could you rebase, then nightly should work again

@WizardOhio24
Copy link
Contributor Author

tui recently updated to 0.12 which allows Text to contain '\n' characters again. I can bump this to 0.12 but due to how tui 0.11 worked, all the Texts have been changed to Span/Spans. Although, the docs for tui do suggest using Span/Spans for multiple lines, https://docs.rs/tui/0.12.0/tui/text/index.html:

These types form a hierarchy: Spans is a collection of Span and each line of Text is a Spans.

@extrawurst
Copy link
Collaborator

@WizardOhio24 ok then lets stick to Span/Spans then. I guess that's the cleaner way to go. I did not check this PR yet, since I want to have the folder-folding stuff sorted before opening the next can :)

@WizardOhio24 WizardOhio24 changed the title Bump tui: 0.9 -> 0.11 Bump tui: 0.9 -> 0.12 Sep 29, 2020
@WizardOhio24 WizardOhio24 mentioned this pull request Oct 4, 2020
@extrawurst
Copy link
Collaborator

extrawurst commented Oct 5, 2020

the line breaks in the commit details windows seem broken:

image

image

@extrawurst extrawurst merged commit 9316863 into gitui-org:master Oct 8, 2020
@extrawurst
Copy link
Collaborator

@WizardOhio24 thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate to tui-rs 0.10
2 participants