-
-
Notifications
You must be signed in to change notification settings - Fork 608
Bump tui: 0.9 -> 0.12 #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There's now no more clippy warnings caused by upgrading tui to 0.11. The deprecations warnings have been fixed and command.print() has been removed. |
4cd9c41
to
03adca9
Compare
@WizardOhio24 could you rebase, then nightly should work again |
03adca9
to
ff7ef0c
Compare
tui recently updated to 0.12 which allows
|
@WizardOhio24 ok then lets stick to |
@WizardOhio24 thanks so much! |
Closes #205, Closes #285
Notable changes:
Text
->Span
Paragraph
was changed such that '\n' no longer creates a new line, ratherSpans
(Vec<Span>
) has to be used where eachSpans
would be a new line(I've tried to fix all the paragraphs but if there is a paragraph which shows its elements horizontally rather than vertically, this PR is most likely the cause)
tui::widgets::Paragraph.title_style() is deprecated and command::CommandInfo.print() is no longer used, should these be fixed in this PR? (They're easy fixes)
Also, the test for line endings in DiffComponent was removed as it no longer applies.