-
-
Notifications
You must be signed in to change notification settings - Fork 607
feat: xclip fallback for linux with xsel #352 #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: xclip fallback for linux with xsel #352 #390
Conversation
Implements #352 |
Thanks @denismaxim0v ❤️Will look into this today |
so this looks ok. could be done a little more readable/scalable by having a list of tools and their arguments and iterate it. but I need a second pair of eyes with a linux machine to test this on either way |
Should I propose another solution in that case? And if so what kind of tools would we include in the list? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good. The gen_command
function could be a bit more generic, but for now this should be fine.
Sorry didn't see this comment before reviewing, but that's basically my only nitpick as well. I for one would like Wayland support eventually, but I can also do that in another PR. |
OK cool, I could participate in another PR too. Anything else needed from me here? |
Let me know if I have any work to do here or should we move to another issue please? |
Co-authored-by: Florian Wilkens <[email protected]>
@denismaxim0v and @1wilkens thanks for your help❤️ |
No description provided.