[WIP] Replace unwrap calls in asyncgit with error handling - closes #53 #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCord
changed the title
MCord
changed the title
MCord
force-pushed
the
issue_53_more_error_handling
branch
from
38ab97d to
3e4d1e9
Compare
Closed
|
Hey @MCord thanks for getting at this! |
extrawurst
reviewed
May 14, 2020
extrawurst
reviewed
May 14, 2020
extrawurst
reviewed
May 14, 2020
removed an obsolete comment.
extrawurst
reviewed
May 14, 2020
|
Really good work! Two more things:
|
|
Thanks ❤️ ! I will remove every unwrap outside the tests and update the PR. I don't mind changing |
extrawurst
reviewed
May 15, 2020
extrawurst
reviewed
May 15, 2020
extrawurst
reviewed
May 15, 2020
extrawurst
reviewed
May 15, 2020
extrawurst
reviewed
May 15, 2020
extrawurst
reviewed
May 15, 2020
extrawurst
reviewed
May 15, 2020
extrawurst
reviewed
May 15, 2020
extrawurst
reviewed
May 15, 2020
extrawurst
reviewed
May 15, 2020
extrawurst
reviewed
May 15, 2020
extrawurst
reviewed
May 15, 2020
extrawurst
reviewed
May 15, 2020
extrawurst
reviewed
May 15, 2020
extrawurst
reviewed
May 15, 2020
extrawurst
reviewed
May 15, 2020
extrawurst
reviewed
May 15, 2020
|
Sorry to be such a pain in the ass 🙈! I am super glad you do all of this! |
My pleasure! sorry you have to micro mange this PR :) It's my first lets hope It gets better with time 😂 |
|
Looks good to me! I will squash merge it if that's ok by you? |
|
Perfect, Thank you.
…On Fri, May 15, 2020 at 3:12 PM Stephan Dilly ***@***.***> wrote:
Looks good to me! I will squash merge it if that's ok by you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#58 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALZWZ7SJGEDVV4GDSYVCBDRRU5U3ANCNFSM4NAVG2FQ>
.
|
|
Thank you @MCord! Great job!👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request tries to replace
unwrap()calls in asyncgit with error handling via a custom error type defined inerror.rs. changes has been split into separate commits.error.rsfile (dependent onthiserrorcrate)Result<T>type alias forResult<T,Error>unwrap()calls fromasyncgitlib except a few in callbacks that I don't know how to deal with for the moment.I have not touched
unwrap()inside tests as I am not sure yet if we want to remove them too. I assume they are alright in tests. I will continue to change other files when I get feedback about the code.