Skip to content

Remove hardcoded white color from selected tab (#719) #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2021
Merged

Remove hardcoded white color from selected tab (#719) #720

merged 1 commit into from
May 21, 2021

Conversation

star-szr
Copy link
Contributor

Screenshots:

fixed-light
fixed-dark

See #719 for "before" screenshots and additional context.

@extrawurst
Copy link
Collaborator

thanks for tackling this, for some reason this was removed in 9316863

@extrawurst extrawurst merged commit d692d32 into gitui-org:master May 21, 2021
@extrawurst
Copy link
Collaborator

closes #719

@star-szr star-szr deleted the selected-tab-hardcoded-white branch May 21, 2021 15:50
@star-szr
Copy link
Contributor Author

@extrawurst thanks! One potential followup (I mentioned a bit in #719) is that I'm not sure the selected_tab theme key does anything currently. At least I can't find any places in the UI that use it. Do you want me to create a separate issue for that?

@extrawurst
Copy link
Collaborator

@extrawurst thanks! One potential followup (I mentioned a bit in #719) is that I'm not sure the selected_tab theme key does anything currently. At least I can't find any places in the UI that use it. Do you want me to create a separate issue for that?

sure file a new issue please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants