Add undo_last_commit command

[remique]

Hey again! I started working on #758 but since it’s not finished yet, I am opening Draft Pull Request. It works, but it’s not finished. Am I going in the right direction with this?

• It does not refresh main tab yet (sometimes). You have to switch between tabs to see the change
• Should there be a popup or some kind of feedback?
• Should undo_last_commit() in utils.rs be more general function, for future use?

[extrawurst]

@remique welcome back!🥳

It does not refresh main tab yet (sometimes). You have to switch between tabs to see the change

you need to send a explicit update request into the queue (check other such functions)

Should there be a popup or some kind of feedback?

only for the error case, see try_or_popup for examples.

Should undo_last_commit() in utils.rs be more general function, for future use?

not sure what you mean?

[remique]

Unittests can probably be done better? Also, while working on this issue I have noticed that there are some commands with my keybinding (u) already assigned. To avoid potential conflicts, I changed undo_commit to SHIFT-U both in default and vim-keybindings (feel like it’s a bit more natural since it’s not the most used command in the world). Hopefully I didn’t forget about anything.

not sure what you mean?

Yeah me neither, nevermind 😄

[extrawurst]

good work @remique - almost there 👍

[remique]

Okay, so this definitely feels more natural of a test. Thank you so much for the help and hopefully everything is ready for the merge now.

[extrawurst]

@remique thanks ❤️