Skip to content

add trace-libgit feature #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 13, 2021
Merged

add trace-libgit feature #905

merged 6 commits into from
Oct 13, 2021

Conversation

dm9pZCAq
Copy link
Contributor

This Pull Request "fixes" #902.

It changes the following:

  • make libgit tracing optional, but enabled by default

I followed the checklist:

  • I added unittests
  • I ran make check without errors
    • not related to PR
  • I tested the overall application
  • I added an appropriate item to the changelog
error from make check
error[E0425]: cannot find function `pthread_getname_np` in crate `libc`
    --> /home/v/.cache/cargo/registry/src/github.1485827954.workers.dev-1ecc6299db9ec823/pprof-0.5.0/src/profiler.rs:112:30
     |
112  |     let ret = unsafe { libc::pthread_getname_np(current_thread, name_ptr, MAX_THREAD_NAME) };
     |                              ^^^^^^^^^^^^^^^^^^ help: a function with a similar name exists: `pthread_getattr_np`
     |
    ::: /home/v/.cache/cargo/registry/src/github.1485827954.workers.dev-1ecc6299db9ec823/libc-0.2.101/src/unix/linux_like/mod.rs:1508:5
     |
1508 |     pub fn pthread_getattr_np(native: ::pthread_t, attr: *mut ::pthread_attr_t) -> ::c_int;
     |     --------------------------------------------------------------------------------------- similarly named function `pthread_getattr_np` defined here

@extrawurst
Copy link
Collaborator

lgtm! can you please update the changelog accordingly and put a note into the readme appropriately?

@dm9pZCAq
Copy link
Contributor Author

dm9pZCAq commented Sep 24, 2021

something like this?

@extrawurst
Copy link
Collaborator

something like this?

well I don't see you adding a note in the readme, but the changelog looks fine. please also bring it up to date with master

@dm9pZCAq
Copy link
Contributor Author

please also bring it up to date with master

sorry about this

I don't see you adding a note in the readme

i don't know where and how should i add this in readme

it can fit into Build and Diagnostics 🤔

do you have any suggestions?

@dm9pZCAq
Copy link
Contributor Author

do you have any suggestions?

no any suggestions? 😢

@extrawurst
Copy link
Collaborator

no any suggestions? 😢

I mean why did you need this change? to make gentoo work, right? so I guess its a good point to add as a note there for others in your position

@dm9pZCAq
Copy link
Contributor Author

@extrawurst
Copy link
Collaborator

yea lets got with that! 👍

@extrawurst extrawurst merged commit 31f6771 into gitui-org:master Oct 13, 2021
extrawurst pushed a commit that referenced this pull request Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants