-
-
Notifications
You must be signed in to change notification settings - Fork 607
add trace-libgit feature #905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lgtm! can you please update the changelog accordingly and put a note into the readme appropriately? |
something like this? |
well I don't see you adding a note in the readme, but the changelog looks fine. please also bring it up to date with master |
sorry about this
i don't know where and how should i add this in readme it can fit into do you have any suggestions? |
no any suggestions? 😢 |
I mean why did you need this change? to make gentoo work, right? so I guess its a good point to add as a note there for others in your position |
yea lets got with that! 👍 |
This Pull Request "fixes" #902.
It changes the following:
libgit
tracing optional, but enabled by defaultI followed the checklist:
make check
without errorserror from
make check