Skip to content

use Path to fix blame filename seperators (#981) #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

extrawurst
Copy link
Collaborator

closes #981

@extrawurst
Copy link
Collaborator Author

@enizor can you please checkout this branch and see if it fixes the issue on windows?

@enizor
Copy link

enizor commented Nov 11, 2021

Still got <no blame available> :/

Without debugging, I'd guess the problem stays the same - PathBuf still uses \ when formatted into a &str while git-revparse-single (asyncgit/src/blame.rs:55) expects /.

@extrawurst extrawurst closed this Nov 12, 2021
@extrawurst extrawurst deleted the blame-file-windows-path branch November 12, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blame file path wrong on windows
2 participants