Handle some errors as nodata #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass error patterns as `errors_as_nodata`, which if raised, will be printed as a warning, and whatever they were trying to load will be returned as an empty array. The main thing I'm unsure about is the `warnings.warn`. In brief testing, it didn't reliably show up, and I'm not sure whether it would show up in distributed worker logs. However, I was also testing a URL that only intermittently failed, so I can't be sure the error was actually happening. I'll likely merge this now, since it's still a significant improvement, but we should come back to the larger logging story. Closes #12
|
Thanks Gabe, I will test it soon when I get a chance. I can do some of the same things I was using last weekend to compare. Retries = more complicated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass error patterns as
errors_as_nodata, which if raised, will be printed as a warning, and whatever they were trying to load will be returned as an empty array. By default,RasterioIOError("HTTP response code: 404")is ignored.The main thing I'm unsure about is the
warnings.warn. In brief testing, it didn't reliably show up, and I'm not sure whether it would show up in distributed worker logs. However, I was also testing a URL that only intermittently failed, so I can't be sure the error was actually happening.I'll likely merge this now, since it's still a significant improvement, but we should come back to the larger logging story. Additionally, this doesn't do anything about retries (#18).
cc @RichardScottOZ
Closes #12