Skip to content

Dependencies should be explicitly set in package.json #15

Closed
@wolfd

Description

@wolfd

Everything directly imported by a file should have a package version set in package.json.
I use pnpm, which disallows relying on phantom dependencies, which causes this package to not work correctly.
For more info on phantom dependencies: https://rushjs.io/pages/advanced/phantom_deps/

https://github.com/gl-vis/gl-cone3d/blob/d686777/lib/conemesh.js#L7-L16

The dependencies that should be added to "dependencies" in package.json are:

  • colormap
  • gl-buffer
  • gl-mat4
  • gl-shader
  • gl-texture2d
  • gl-vao
  • ndarray
  • normals
  • simplicial-complex-contour
  • typedarray-pool

(this is essentially the same issue as gl-vis/gl-streamtube3d#9)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions