Skip to content

Fix contours when first level has length zero #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

etpinard
Copy link
Member

@etpinard etpinard commented Jun 8, 2018

See https://codepen.io/etpinard/pen/pKNBdr where the 'x' contours fail to set contourColor uniform to [0,0,0,1].

etpinard added a commit to plotly/plotly.js that referenced this pull request Jun 8, 2018
etpinard added a commit to plotly/plotly.js that referenced this pull request Jun 8, 2018
@alexcjohnson
Copy link

Good find!

@etpinard etpinard merged commit 1edcbe3 into master Jun 11, 2018
@etpinard etpinard deleted the fix-contours-when-first-level-has-length-zero branch June 11, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants