This repository was archived by the owner on Feb 7, 2024. It is now read-only.
(GH-10) Account for legacy style version requirement in module metadata#11
Merged
Conversation
Previously the resolver assumed that all module version requirements would be specified using version_requirements [1]. However extremely old modules on the Puppet Forge still use the old version_range parameter, for example PUP-2781 [2] This commit updates the module specification parser to try the correct name, then the old legacy name and then revert to an open dependency (>= 0). This commit also adds tests for these scenarios \ [1] https://puppet.com/docs/puppet/latest/modules_metadata.html#specifying-dependencies [2] https://tickets.puppetlabs.com/browse/PUP-2781
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10
Previously the resolver assumed that all module version requirements would be
specified using version_requirements [1]. However extremely old modules on the
Puppet Forge still use the old version_range parameter, for example PUP-2781 [2]
This commit updates the module specification parser to try the correct name,
then the old legacy name and then revert to an open dependency (>= 0).
This commit also adds tests for these scenarios
[1] https://puppet.com/docs/puppet/latest/modules_metadata.html#specifying-dependencies
[2] https://tickets.puppetlabs.com/browse/PUP-2781