Skip to content

Update test expectations #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Update test expectations #297

merged 3 commits into from
Feb 19, 2024

Conversation

teunbrand
Copy link
Contributor

@teunbrand teunbrand commented Jan 18, 2024

Description

Context

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break manydata.

Changes in this PR

This PR updates fragile tests expectations from fixed values to values derived from ggplot2. The suggested changes should pass for current CRAN ggplot2 and the incoming update.

More information

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help manydata get out a fix if necessary.

Checklist:

  • PR form
    • I have given this pull request an informative title
    • Description above itemizes changes under subtitles, e.g. "## Collection""
    • Any closed, fixed, or related issues are referenced and explained in the description above, e.g. "Fixed #0 by adding A"
    • Package builds on my OS without issues
  • PR checks all pass for latest commit
    • Package builds on Mac
    • Package builds on Windows
    • Package builds on Linux
    • CodeCov check: Package improves or maintains good test coverage
    • CodeFactor check: Package improves or maintains good style
  • Documentation
    • Any new or modified functions or data have roxygen style documentation in their .R scripts
    • Any longer functions are commented inline so that it is easier to debug in the future
    • PR description above and the NEWS.md file are aligned
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)

henriquesposito and others added 3 commits July 4, 2023 15:53
#minor Re-structured package functions around `call_` and `compare_` family of functions
#minor Fixes deployment issues with previous PR #260
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (54c9f9c) 74.13% compared to head (bf526b1) 74.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   74.13%   74.26%   +0.13%     
==========================================
  Files           5        5              
  Lines         750      750              
==========================================
+ Hits          556      557       +1     
+ Misses        194      193       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teunbrand
Copy link
Contributor Author

This is just a friendly reminder that the release of ggplot2 is scheduled soon.

@henriquesposito henriquesposito changed the base branch from main to develop February 19, 2024 09:07
@henriquesposito henriquesposito merged commit 6a093dc into globalgov:develop Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants