1.3-rc0 fractional seconds nor milliseconds working for date skeletons

[mattyork]

1.3-rc is looking good, but this is blocking us right now.

Repro!

const ianaTzData = require('iana-tz-data');
const Globalize = require("globalize");
const cldrData = require('./vendor/cldr-data.json');
Globalize.loadTimeZone(ianaTzData);
Globalize.load(cldrData);
Globalize.locale("en");

const date = new Date();
const d1 = Globalize.dateFormatter({ skeleton: "yyyyMMddjjmmssSSS" })
console.log(d1(date))
const d2 = Globalize.dateFormatter({ skeleton: "yyyyMMddjjmmssAAA" })
console.log(d2(date))

Expected to see fractional seconds and milliseconds according to this: http://www.unicode.org/reports/tr35/tr35-dates.html#dfst-second

Actual Output:

D:\gitlab\localize> node .\test.js
06/30/2017, 02:00:00037 PM
06/30/2017

[rxaviers]

Hi! Thanks for submitting this issue. In addition to your description, follow what ICU returns for comparison: https://ssl.icu-project.org/icu4jweb/flexTest.jsp?pat=yyyyMMddjjmmssSSS&_=en_US

For instance, "06/30/2017, 2:03:17.423 PM" for en-US.

[rxaviers]

The existing skeleton expand-pattern algorithm doesn't handle S. 😩

It should implement the following:

A requested skeleton that includes both seconds and fractional seconds (e.g. “mmssSSS”) is allowed to match a dateFormatItem skeleton that includes seconds but not fractional seconds (e.g. “ms”). In this case the requested sequence of ‘S’ characters (or its length) should be retained separately and used when adjusting the pattern, as described below.
...
If the requested skeleton included both seconds and fractional seconds and the dateFormatItem skeleton included seconds but not fractional seconds, then the seconds field of the corresponding pattern should be adjusted by appending the locale’s decimal separator, followed by the sequence of ‘S’ characters from the requested skeleton.

http://www.unicode.org/reports/tr35/tr35-dates.html#Matching_Skeletons

[rxaviers]

Would you like to work on that?

[mattyork]

PR sent!

[rxaviers]

Awesome!

[jhaverhals]

In which release can I expect the fix for this issue?

[sigalvo]

Hi,
Are there any news on this fix?

[rxaviers]

The delay merging and releasing this is on my side, but it will happen this month 🙈

[sigalvo]

Great! thanks

[jhaverhals]

Is there something you could share already?