PlaybackRateController updated for virtual keys and further development #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures for playback speed control. PlaybackRateController now check both event.key and event.code from a list so that multiple key variances can be added for different keyboard layouts.Commited Closes gmertes#53
gmertes
reviewed
Apr 1, 2025
src/playback-rate-controller.js
Outdated
Comment on lines
44
to
45
| if (allowedEventCodes.playbackRateDecreaserKeys.includes(t.code) || allowedEventKeys.playbackRateDecreaserKeys.includes(t.key)) playbackRate -= 0.1; | ||
| else if (allowedEventCodes.playbackRateIncreaserKeys.includes(t.code) || allowedEventKeys.playbackRateIncreaserKeys.includes(t.key)) playbackRate += 0.1; |
Owner
There was a problem hiding this comment.
That should be evt.code and evt.key
Closes gmertes#53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: allow virtual keystroke simulation that sends mixed event structures for playback speed control. PlaybackRateController now check both event.key and event.code from a list so that multiple key variances can be added for different keyboard layouts.Commited
Closes #53