Skip to content

Support LLVM 3.9 #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zimmski opened this issue Sep 5, 2016 · 11 comments
Closed

Support LLVM 3.9 #117

zimmski opened this issue Sep 5, 2016 · 11 comments

Comments

@zimmski
Copy link
Member

zimmski commented Sep 5, 2016

LLVM 3.9 is out
http://llvm.org/releases/3.9.0/docs/ReleaseNotes.html
http://llvm.org/releases/3.9.0/tools/clang/docs/ReleaseNotes.html

@zimmski
Copy link
Member Author

zimmski commented Sep 12, 2016

TravisCI says it cannot find the packages, but they are whiteflagged here https://github.com/travis-ci/apt-package-whitelist/blob/master/ubuntu-precise

@zchee
Copy link
Member

zchee commented Sep 12, 2016

@zimmski No, travis still does not add 3.9 apt-source to the white list.
See https://github.com/travis-ci/apt-source-whitelist/blob/master/ubuntu.json#L182-L206

It's a bug(?).
But we can be requesting. https://github.com/travis-ci/apt-source-whitelist#source-approval-process

Edit: Sorry if you already know :(

BTW, What do you think to use Docker container travis test?
I saw #103. Maybe it PR for users, but can be used travis test too. (and maybe no limiting? because sandboxed with the container)
And, it might be can testing with the LLVM's HEAD(4.0 dev) use http://apt.llvm.org if want.

But it will take more time than CI until now.

@zimmski
Copy link
Member Author

zimmski commented Sep 13, 2016

It baffles me why the packages are whiteflagged but their source is not. I will start the process. Hopefully they react soonish.

Please open up a new issue for your Docker/4.0 question.

@zimmski
Copy link
Member Author

zimmski commented Sep 13, 2016

We are waiting for travis-ci/apt-source-safelist#300

@zimmski
Copy link
Member Author

zimmski commented Sep 13, 2016

Whoever is trying this out before we close the 3.9 issue: The 3.9 version repository has no working TravisCI build but it works locally here on my machine.

@FrankReh
Copy link

With OS X 10.11, go 1.7.1 and llvm/clang 3.9, this works for me too. Nice!

On Tue, Sep 13, 2016 at 4:48 AM, Markus Zimmermann <[email protected]

wrote:

Whoever is trying this out before we close the 3.9 issue: The 3.9 version
repository has no working TravisCI build but it works locally here on my
machine.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#117 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFdfOM74nFxhCVMK0cUL7_2tsRACCSRFks5qpmN5gaJpZM4J033U
.

@zimmski
Copy link
Member Author

zimmski commented Sep 13, 2016

@FrankReh Awesome! Do you have a use-case we could reuse for our tests?

@FrankReh
Copy link

My two uses have too many outside dependancies at the moment. But I mean
to create some smaller standalone unit tests anyway and I'll send them your
way when they are ready. Really glad to see you could leverage your hard
work for the first generated ports towards 3.8 and 3.9. Also glad you
found a way to work around the GO GC rule that had kept the visitor
function from being defined as a closure around local variables. I haven't
had time to see how you did that - I thought I was going to have to live
with defining everything globally.

On Tue, Sep 13, 2016 at 11:56 AM, Markus Zimmermann <
[email protected]> wrote:

@FrankReh https://github.com/FrankReh Awesome! Do you have a use-case
we could reuse for our tests?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#117 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFdfOGSVCx5G7zosXktNwpTTbQXydRByks5qpsevgaJpZM4J033U
.

@zimmski
Copy link
Member Author

zimmski commented Sep 14, 2016

@FrankReh The PR for the visitor change is here go-clang/bootstrap#10. I'm glad you like what we did 😄 Some more tests would be superb and there are also some open issues [https://github.com/go-clang/gen/issues] if you are interested

@zimmski
Copy link
Member Author

zimmski commented Mar 14, 2017

Looks like the blocking issue has been closed by another request but the TravisCI guys forget to resolve our blocker.

@zimmski zimmski closed this as completed Mar 14, 2017
@zimmski
Copy link
Member Author

zimmski commented Mar 14, 2017

I pressed rebuild and the build is now green https://travis-ci.org/go-clang/v3.9 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants