Skip to content

Conversation

@derekparker
Copy link
Member

Implement the specific behavior we used from the gotetk/gore library without copying any code to avoid licensing issues.

Fixes #3661

@derekparker
Copy link
Member Author

Currently marking as draft, this PR still needs work but I wanted to push for awareness on the upcoming change.

Still to do:

  • Document offsets used when digging through moduledata
  • Support 32-bit
  • Support Darwin

@derekparker derekparker marked this pull request as ready for review February 20, 2024 21:43
Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aarzilli aarzilli merged commit 4a72c52 into go-delve:master Feb 21, 2024
@aktau
Copy link

aktau commented Feb 21, 2024

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Highlight (new) AGPL (Affero General Public License dependency go-delve/gore

3 participants