Skip to content

all: import go telemetry and enable crash reporting #3841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

all: import go telemetry and enable crash reporting #3841

merged 1 commit into from
Oct 29, 2024

Conversation

@hyangah
Copy link
Contributor

@hyangah hyangah commented Oct 25, 2024 •
edited
Loading

Imported golang.org/x/telemetry@9c0d19e to avoid
go version requirement change.

For #3815
For golang/go#70056

@hyangah hyangah changed the title all: import go telemetry and enable crash reporting all: import go telemetry and enable crash reporting [WIP] Oct 25, 2024
@hyangah
Copy link
Contributor Author

hyangah commented Oct 25, 2024

I got the following failure locally already. Keep looking.

--- FAIL: TestClientServer_SinglelineStringFormattedWithBigInts (1.17s)
    integration2_test.go:2786: constant: "8180A06000000000"
    integration2_test.go:2808: "9331634762088972288" "8180A06000000000"
    integration2_test.go:2808: "9331634762088972288" "8180A06000000000"
    integration2_test.go:2808: "9259436018245828608" "8080200000000000"
    integration2_test.go:2808: "9259436018245828608" "8080200000000000"
    integration2_test.go:2808: "0" "0"
panic: runtime error: index out of range [8] with length 8 [recovered]
        panic: runtime error: index out of range [8] with length 8

goroutine 1296 [running]:
testing.tRunner.func1.2({0x7b6e3c0, 0xc028d2a198})
        /Users/hakim/sdk/go1.23.1/src/testing/testing.go:1632 +0x230
testing.tRunner.func1()
        /Users/hakim/sdk/go1.23.1/src/testing/testing.go:1635 +0x35e
panic({0x7b6e3c0?, 0xc028d2a198?})
        /Users/hakim/sdk/go1.23.1/src/runtime/panic.go:785 +0x132
github.com/go-delve/delve/service/test_test.TestClientServer_SinglelineStringFormattedWithBigInts.func1({0x7bbf588, 0xc02a376f90}, {{0x799c3d8, 0x9}, {0xc00873a820, 0x43}, {0xc027a04690, 0x28}, {0xc027a04720, 0x2f}})
        /Users/hakim/projects/delve/service/test/integration2_test.go:2809 +0x836
github.com/go-delve/delve/service/test_test.withTestClient2Extended({0x799c3d8?, 0x100000001?}, 0xc004649750?, 0x74784d6?, {{0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0}}, ...)
        /Users/hakim/projects/delve/service/test/integration2_test.go:105 +0x191
github.com/go-delve/delve/service/test_test.TestClientServer_SinglelineStringFormattedWithBigInts(0xc0095f6820?)
        /Users/hakim/projects/delve/service/test/integration2_test.go:2775 +0x58
testing.tRunner(0xc0095f6820, 0x7ba9350)
        /Users/hakim/sdk/go1.23.1/src/testing/testing.go:1690 +0xf4
created by testing.(*T).Run in goroutine 1
        /Users/hakim/sdk/go1.23.1/src/testing/testing.go:1743 +0x390
FAIL    github.com/go-delve/delve/service/test  469.787s
FAIL

@aarzilli
Copy link
Member

aarzilli commented Oct 25, 2024

I got the following failure locally already. Keep looking.

Are you using a weird version of Go?

@aarzilli
Copy link
Member

aarzilli commented Oct 25, 2024

The bump to 1.22 is problematic, 1.21 will be in the test matrix for a while.

@hyangah
all: import go telemetry and enable crash reporting
674444a 
Imported golang.org/x/telemetry@9c0d19e to avoid
go version requirement change.

For go-delve#3815
For golang/go#70056
aarzilli
aarzilli approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aarzilli
Copy link
Member

aarzilli commented Oct 28, 2024

Thanks!

@hyangah hyangah changed the title all: import go telemetry and enable crash reporting [WIP] all: import go telemetry and enable crash reporting Oct 29, 2024
derekparker
derekparker approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit ac8b471 into go-delve:master Oct 29, 2024
2 checks passed
@derekparker
Copy link
Member

derekparker commented Oct 29, 2024

Thank you!

@BrewTestBot BrewTestBot mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aarzilli aarzilli aarzilli approved these changes

@derekparker derekparker derekparker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hyangah @aarzilli @derekparker