Skip to content

Conversation

@aarzilli
Copy link
Member

dwarf/line: default file for DWARFv5 fix

temp2

temp -- fix dwarf5 bugs

@aarzilli aarzilli marked this pull request as draft December 31, 2024 10:14
Copy link
Contributor

@thanm thanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good.

@derekparker
Copy link
Member

@aarzilli mind polishing this up and taking it off draft? I'd like to pull this in as it fixes the test suite locally on my Mac running the latest macOS version.

Miscellaneous fixes to our DWARFv5 implementation, several contributed by @thanm.
@aarzilli aarzilli marked this pull request as ready for review February 28, 2025 06:12
@aarzilli aarzilli changed the title DWARFv5 fixes (WIP) DWARFv5 fixes Feb 28, 2025
@aarzilli
Copy link
Member Author

I had already cleaned the commit up last week, I just forgot to undraft it.

Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@derekparker derekparker merged commit e6e7aeb into go-delve:master Mar 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants