fix(services/dap) fix race condition when launching with backend=rr #3971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarzilli
reviewed
Apr 4, 2025
service/dap/server.go
Outdated
|
|
||
| if s.debugger != nil { | ||
| s.debugger.LockTarget() | ||
| // Unlock immediatey, otherwise ProcessPid() will hang waiting for the mutex |
Member
There was a problem hiding this comment.
This should be:
s.debugger.LockTarget()
cmdLine := s.debugger.Target().CmdLine
s.debugger.UnlockTarget()
and then cmdLine is used later instead s.debugger.Target().CmdLine.
Contributor
Author
There was a problem hiding this comment.
Yeah, you're absolutely right!
I'll update this commit.
I've also gone through the debugger's public methods and there are some more missing targetMutex.Lock(). Details are in this comment on the issue. I'd love a pointer as to whether it is preferrable for me to just add the missing mutex locks
BronzeDeer
force-pushed
the
fix-dap-rr-race-condition
branch
from
aa5666f to
0e41fac
Compare
Contributor
Author
|
Updated with changes suggested in #3971 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3970
As discussed in #3970 (comment) it might be better to put Target() and TargetGroup() (and some other public methods) under mutex protection as well for a more comprehensible fix