*: fix some failing tests on go1.25#4089
Merged
Merged
Conversation
* Skip TestIssue256 on linux/386, it fails because the line it relies on (a return) does not have code generated for it. * Skip running gen-usage-docs in TestGeneratedDocs on linux/ppc64le, I don't know why this fails, likely just a problem with the build agent, but it doesn't matter: the test doesn't need to run on every architecture. * Change TestRestartRequestWithNewArgs so that it doesn't depend on the cap value of a slice (it changed in go1.25/windows/amd64)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip TestIssue256 on linux/386, it fails because the line it relies
on
(a return) does not have code generated for it.
Skip running gen-usage-docs in TestGeneratedDocs on linux/ppc64le, I
don't know why this fails, likely just a problem with the build
agent,
but it doesn't matter: the test doesn't need to run on every
architecture.
Change TestRestartRequestWithNewArgs so that it doesn't depend on the
cap value of a slice (it changed in go1.25/windows/amd64)