service/dap: set seq number for response messages#4280
Merged
Conversation
aarzilli
force-pushed
the
dapseq
branch
2 times, most recently
from
8a77df4 to
8d46fd6
Compare
derekparker
reviewed
Mar 9, 2026
The DAP specification says that messages sent from the server to the client should have a seq number but we never did do that because the original DAP extension didn't. Add sequence numbers, even though it doesn't seem to cause problems in practice, to conform to the protocol specification. Fixes go-delve#2245
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DAP specification says that messages sent from the server to the
client should have a seq number but we never did do that because the
original DAP extension didn't.
Add sequence numbers, even though it doesn't seem to cause problems in
practice, to conform to the protocol specification.
Fixes #2245