Skip to content

chore: remove unnecessary target platfrom #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2020
Merged

Conversation

pchampio
Copy link
Member

@pchampio pchampio requested a review from GeertJohan May 23, 2020 15:22
@provokateurin
Copy link
Member

Does creating a new main file even make sense then? I mean it just executes the real main function and does nothing else. Most peoply don't change the file so we could just remove it (but still keep backwards compatability).

@pchampio
Copy link
Member Author

I personally like the separation. I agree, this file isn't needed anymore.
WIll have to talk with @GeertJohan , this PR can be a first good starting point for slowly updating the default behavior.

@GeertJohan
Copy link
Member

I agree we can move towards removing the main_desktop.dart all together.

If someone needs a separate main file for their destop environment, they could use --target or the hover.yaml target field to set the alternative entrypoint.

Merging this MR already, we can have a separate PR for removing main_dekstop.dart generation and changing the defaults (that will be breaking for people who have custom stuff in their main_desktop.dart).

@GeertJohan GeertJohan merged commit 3f6d9fb into master May 24, 2020
@GeertJohan GeertJohan deleted the rm_target_plat branch May 24, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Target platfrom linux & windows available
3 participants