fix: go 1.13 avoid go PROXY. #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.13 introduced a proxy for go modules versioning. This proxy doesn't allow to `go get` package that have '/' in the version string. eg `go get github.com/go-flutter-desktop/[email protected]` works. But `go get get github.com/go-flutter-desktop/go-flutter@feature/test` wont because of the '/' after the '@'. The issue is reported in golang/go#32955 A fix is to by-pass the PROXY by using the `GOPROXY=direct` venv. Go 1.13 also doesn't fetch '@latest' when the tag is already valid. This commit sets '@latest' to the version string when needed (hover upgrade)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.13 introduced a proxy for go modules versioning.
This proxy doesn't allow to
go getpackage that have '/' in theversion string.
eg
go get github.com/go-flutter-desktop/[email protected]works.But
go get get github.com/go-flutter-desktop/go-flutter@feature/testwont because of the '/' after the '@'.
The issue is reported in golang/go#32955
A fix is to by-pass the PROXY by using the
GOPROXY=directvenv.Go 1.13 also doesn't fetch '@latest' when the tag is already valid.
This commit sets '@latest' to the version string when needed (hover upgrade)