Skip to content

拡張インデックス対応 #4 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 77 commits into from
May 14, 2020
Merged

拡張インデックス対応 #4 #6

merged 77 commits into from
May 14, 2020

Conversation

54m
Copy link
Member

@54m 54m commented May 7, 2020 •
edited
Loading

Query検索を追加
拡張インデックス対応
カスタムインデックス対応
Transactionに対応

@54m 54m linked an issue May 7, 2020 that may be closed by this pull request
LIKEなど拡張インデックスに対応させる #4
Closed
@54m 54m force-pushed the issue/4/master branch from 838902c to d107f29 Compare May 7, 2020 06:46
@54m 54m self-assigned this May 7, 2020
@54m 54m changed the title WIP #4 拡張インデックス対応 #4 May 8, 2020
@54m 54m force-pushed the issue/4/master branch from ccaf651 to 7d751b1 Compare May 8, 2020 11:31
@54m 54m force-pushed the issue/4/master branch from 13f49dd to 9826594 Compare May 11, 2020 07:53
@54m 54m requested review from moezakura and tsuzu and removed request for tsuzu May 12, 2020 06:03
moezakura
moezakura requested changes May 12, 2020
View reviewed changes
Copy link
Member

@moezakura moezakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつかコメントしました。

moezakura
moezakura approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@moezakura moezakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@54m 54m linked an issue May 13, 2020 that may be closed by this pull request
Transactionを考慮 #11
Closed
@54m 54m force-pushed the issue/4/master branch from c5eafde to e9f7931 Compare May 13, 2020 10:37
tsuzu
tsuzu reviewed May 14, 2020
View reviewed changes
Copy link
Collaborator

@tsuzu tsuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点だけ確認お願いしたいです 🙇

tsuzu
tsuzu approved these changes May 14, 2020
View reviewed changes
Copy link
Collaborator

@tsuzu tsuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉
Thanks

@tsuzu tsuzu merged commit e37353b into master May 14, 2020
@tsuzu tsuzu deleted the issue/4/master branch May 14, 2020 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsuzu tsuzu tsuzu approved these changes

@moezakura moezakura moezakura approved these changes

Assignees

@54m 54m

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@54m @tsuzu @moezakura