Skip to content
This repository was archived by the owner on Apr 12, 2019. It is now read-only.

Add repo_blob #121

Closed
wants to merge 1 commit into from
Closed

Add repo_blob #121

wants to merge 1 commit into from

Conversation

clee
Copy link

@clee clee commented Jun 4, 2018

This adds a new Repository.GetBlob(id) method for use by gitea.

Part of an attempt to fix go-gitea/gitea#4048.

@lunny
Copy link
Member

lunny commented Jun 5, 2018

@clee could you add some unit test?

@clee
Copy link
Author

clee commented Jun 5, 2018

@lunny I added a test for GetBlob, but, uh... maybe I'm doing something wrong? Try running the test and see what you get. Is Blob.Data() returning the right data?

This adds a new Repository.GetBlob(id) method for use by gitea.
@clee clee force-pushed the add-repo-blob branch from 2a86ce9 to 26fb1c7 Compare June 5, 2018 07:36
@clee
Copy link
Author

clee commented Jun 5, 2018

I think I figured it out. I copied the Blob initializer from blob_test.go, and it's setting the ptree to the root of the repository. I need to figure out how to rebuild the parent tree from just having the SHA.

@ghost
Copy link

ghost commented Jul 21, 2018

Any update?

@HoffmannP HoffmannP mentioned this pull request Nov 10, 2018
@lafriks
Copy link
Member

lafriks commented Nov 11, 2018

Closing in favour of #132

@lafriks lafriks closed this Nov 11, 2018
lafriks pushed a commit that referenced this pull request Nov 11, 2018
* Add repo_blob

This adds a new Repository.GetBlob(id) method for use by gitea.

* This is a follow-up for PR #121 to implement blob_api including full test coverage

Signed-off-by: Berengar W. Lehr <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide support for blob url
4 participants