Skip to content

Commit b28c4f2

Browse files
GiteaBotsilverwindclaude
authored
fix(actions): fix blank lines after ::endgroup:: (#37597) (#37612)
Backport #37597 by @silverwind `endLogGroup` was incorrectly appending empty `<div>`s, producing a useless blank line after every group. Before and after: <img width="250" alt="Screenshot 2026-05-07 at 22 40 40" src="https://github.com/user-attachments/assets/8baf0fd0-99c8-4648-bf3f-edc6c4b197ec" /> <img width="250" alt="Screenshot 2026-05-07 at 22 37 12" src="https://github.com/user-attachments/assets/c45f28ae-1bbf-4b25-9d7b-281c19421f63" /> Signed-off-by: silverwind <me@silverwind.io> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Claude (Opus 4.7) <noreply@anthropic.com>
1 parent 677ab98 commit b28c4f2

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

web_src/js/components/ActionRunJobView.vue

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -197,10 +197,9 @@ function beginLogGroup(stepIndex: number, startTime: number, line: LogLine, cmd:
197197
}
198198
199199
// end a log group
200-
function endLogGroup(stepIndex: number, startTime: number, line: LogLine, cmd: LogLineCommand) {
200+
function endLogGroup(stepIndex: number) {
201201
const el = getJobStepLogsContainer(stepIndex);
202202
el._stepLogsActiveContainer = undefined;
203-
el.append(createLogLine(stepIndex, startTime, line, cmd));
204203
}
205204
206205
// show/hide the step logs for a step
@@ -254,7 +253,7 @@ function appendLogs(stepIndex: number, startTime: number, logLines: LogLine[]) {
254253
beginLogGroup(stepIndex, startTime, line, cmd);
255254
continue;
256255
case 'endgroup':
257-
endLogGroup(stepIndex, startTime, line, cmd);
256+
endLogGroup(stepIndex);
258257
continue;
259258
}
260259
// the active logs container may change during the loop, for example: entering and leaving a group

0 commit comments

Comments
 (0)