Default command timeout used for git archive

[fpiecka]

• Gitea version (or commit ref): 1.11.5
• Git version: 2.11.0
• Operating system: Debian 9
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant (issue depends on hosting machine performance and repo content, but it should be reproducible)
• Log gist: Nothing can be found in logs, which I consider a bug too. Could we log timeout reached as ERROR or at least WARNING?

Description

We have a 700MB+ release in ZIP format which cannot be downloaded from gitea.

Manually running git archive (using the same parameters as gitea runs it with) takes 1m3.466s of real time (0m53.936s user + 0m6.416s system) on our machine. It seems it is just over 60 second limit defined in:

gitea/modules/git/command.go

Lines 24 to 25 in c8d7ae1

	// DefaultCommandExecutionTimeout default command execution timeout duration
	DefaultCommandExecutionTimeout = 60 * time.Second

I can see git archive is called without a specific timeout set:

gitea/modules/git/commit_archive.go

Line 61 in c8d7ae1

_, err := NewCommand(args...).RunInDir(c.repo.Path)

git.timeout/DEFAULT should be used instead of DefaultCommandExecutionTimeout.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[stale]

This issue has been automatically closed because of inactivity. You can re-open it if needed.