Complete convert method (add alter ROW_FORMAT=DYNAMIC)

[camlafit]

• Gitea version (or commit ref): 1.11.5 P
• Git version: 2.x
• Operating system: Debian
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

gitea convert` break on conversion with oauth_* tables about key length.

Server is correctly set with mysqld options :

• innodb_large_prefix=true
• innodb_file_format=barracuda
• innodb_file_per_table=1

Gitea can't alter charset because row_format is not updated.

To solve

To allow gitea to convert without error, could be nice to set row_format=dynamic before all charset/collate change.
alter table oauth_table ROW_FORMAT=DYNAMIC; is enough.

Second point when conversion is done , a link to https://github.com/go-gitea/gitea/blob/master/custom/conf/app.example.ini#L378-L380 could usefull to administrator to know how to change gitea config.

thanks

[lunny]

@camlafit Could you send a PR for that?

[camlafit]

Hello I could be but I need at least a pointer to know where to start. I'm not golang/gitea fluent :) I think could be a trivial patch. Km

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[lunny]

Now we change the default charset as utf8mb4, this maybe a necessary work.

[camlafit]

Hello

I've forgot this issue. I can redo a check. Any idea how to start this PR ?

[lunny]

resolved by #12804