-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Emojis are too huge #12312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Which specific version of gitea are you using? |
Reproduced on try Looks like some combination of these styles Lines 1225 to 1256 in 7744b36
|
Strange that some of these emojis are wrapped in For this issue: I think Emojis should not be rendered bigger than the current line height, e.g. not increase the line spacing, like here: GitHub is using |
Seems like one is a bug not detecting the sunglasses emoji which is strange (will look at). The size difference of emojis in general is intentional as it is what github/gitlab do also. Gitlab is 1.5em maybe Github used to be and it is now 1.25 after their recent change? I'm fine if people want to change it to 1.25 instead of 1.5 it was initially just copied from one of those. |
I can probably do the necessary styling tweaks. I think 1.25 is ideal and it's what I've been proposing in the original emoji PR too. |
#12317 for the 1.25em. |
I don't know, I've discovered this issue on Codeberg after their big update which was announced heavily. |
Previous tests weren't complicated enough so there were some situations where emojis were't detected properly. Find the earliest occurance in addition to checking for the longest combination. Fixes go-gitea#12312
* Fix emoji detection certain cases Previous tests weren't complicated enough so there were some situations where emojis were't detected properly. Find the earliest occurance in addition to checking for the longest combination. Fixes #12312 * ok spell bot Co-authored-by: Lauris BH <[email protected]>
* Fix emoji detection certain cases Previous tests weren't complicated enough so there were some situations where emojis were't detected properly. Find the earliest occurance in addition to checking for the longest combination. Fixes go-gitea#12312 * ok spell bot Co-authored-by: Lauris BH <[email protected]>
* Fix emoji detection in certain cases (#12320) * Fix emoji detection certain cases Previous tests weren't complicated enough so there were some situations where emojis were't detected properly. Find the earliest occurance in addition to checking for the longest combination. Fixes #12312 * ok spell bot Co-authored-by: Lauris BH <[email protected]> * Reduce emoji size (#12317) * Reduce emoji size Rendering should now pretty much match GitHub with 1.25em. I verified that emojis don't increase the line height and removed unecessary size overrides because now all emojis should appear similar in relation to the font size. * fix reaction hover Co-authored-by: mrsdizzie <[email protected]> Co-authored-by: Lauris BH <[email protected]>
In the new Gitea version, many emojis are displayed too huge. For example, they don't fit in regular text. These are some examples on Github: ππ€ͺππ€β They just fit. That's what they look like in Gitea:
The text was updated successfully, but these errors were encountered: