Skip to content

"New line" not respected when referencing issue from commit #12541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 4 tasks
mind-overflow opened this issue Aug 20, 2020 · 6 comments
Open
1 of 4 tasks

"New line" not respected when referencing issue from commit #12541

mind-overflow opened this issue Aug 20, 2020 · 6 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI

Comments

@mind-overflow
Copy link

mind-overflow commented Aug 20, 2020

  • Gitea version (or commit ref): 1.12.3
  • Git version: 2.17.1
  • Operating system: Ubuntu 20.04 LTS
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite

Description

When a new commit (that references an issue) is pushed, newlines are ignored in the issue page.
This makes the commit text very hard to read/comprehend, and is bad for UX.
On GitHub, the text is rendered correctly.

Screenshots

Gitea

gitea

GitHub

github

@silverwind
Copy link
Member

silverwind commented Aug 21, 2020

This also affects the frontpage newsfeed. I think we need one shared template for abbreviated content that is expandable (both commit messages and issue text which also suffers from this). Thought I guess issue comments may need a different mechanism, so I'm fine with just fixing this isolated case.

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Aug 21, 2020
@mind-overflow
Copy link
Author

This also affects the frontpage newsfeed. I think we need one shared template for abbreviated content that is expandable (both commit messages and issue text which also suffers from this). Thought I guess issue comments may need a different mechanism, so I'm fine with just fixing this isolated case.

Agreed, I think handling it the GitHub way is probably the best. You only see the commit title, then if you click the three small dots it expands and shows you the whole commit body. Clean and compact, but expandable in case you need it.

@silverwind
Copy link
Member

Yes, we have this mechanism already for the last commit on the repo page, so it should be easy to replicate into the discussion list.

@stale
Copy link

stale bot commented Oct 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Oct 21, 2020
@silverwind
Copy link
Member

valid

@stale stale bot removed the issue/stale label Oct 21, 2020
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Oct 21, 2020
@mind-overflow
Copy link
Author

Just a reminder that this issue is still present. Thank you so much for all the great work <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

No branches or pull requests

4 participants