Skip to content

Only show commit title in issue history when referencing an issue #3626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 7 tasks
mbger opened this issue Mar 5, 2018 · 3 comments
Closed
1 of 7 tasks

Only show commit title in issue history when referencing an issue #3626

mbger opened this issue Mar 5, 2018 · 3 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@mbger
Copy link

mbger commented Mar 5, 2018

  • Gitea version (or commit ref): 171914e
  • Git version:
  • Operating system:
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes
    • No
    • Not relevant

Description

I couldn't find an issue which already mentions this but this may have come up before (and it's obviously not a bug).

According to the Git Book it's good practice that commit messages should contain a concise title followed by a more detailed description separated with a blank line:

... As a general rule, your messages should start with a single line that’s no more than about 50 characters and that describes the changeset concisely, followed by a blank line, followed by a more detailed explanation.

When following this suggestion, gitea's UI for any referenced issue gets somewhat bloated. I think it may be a good idea to only show the title of the commit message to keep the history timeline more compact. Optionally, there could be an ellipses button (or sth similar) which expands the complete commit message. Below is a screenshot using Tim Pope's commit message template

Screenshots

commit-reference

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Mar 7, 2018
@stale
Copy link

stale bot commented Feb 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@adelowo
Copy link
Member

adelowo commented Feb 8, 2019

Unstale

Good bot :)

@stale stale bot removed the issue/stale label Feb 8, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Feb 8, 2019
@mrsdizzie
Copy link
Member

Duplicate of #12541 (this one came first but the other has more recent activity/likely to get the issue fixed)

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

5 participants