Cron ignores NO_SUCCESS_NOTICE = true setting

[rozhuk-im]

• Gitea version (or commit ref): 1.12.5
• Git version: 2.28.0
• Operating system: FreeBSD 12.2 amd64
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

I have set all NO_SUCCESS_NOTICE = true but got in logs:

Cron: Reinitialize all missing Git repositories for which records exist has finished
Cron: Delete all repositories missing their Git files has finished
Cron: Delete old repository archives has finished
Cron: Check all repository statistics has finished
Cron: Update migration poster IDs has finished
Cron: Clean-up deleted branches has finished
Cron: Update Mirrors has finished
Cron: Update Mirrors has finished

I prefer not see this, and see only errors in log, that requires some actions from me.
It is hard to filter spam from Cron to find important events.

[zeripath]

In the logs or in the system notice?

[rozhuk-im]

In "System Notices".

[rozhuk-im]

gitea/modules/cron/tasks.go

Line 101 in 48598a7

if config.DoNoticeOnSuccess() {

gitea/modules/cron/setting.go

Line 59 in 48598a7

func (b *BaseConfig) DoNoticeOnSuccess() bool {

But I see no sec.Key("NO_SUCCESS_NOTICE").MustBool(true) in project, like all other cron tasks variables.

[zeripath]

That's because it is not set to true by default.

[rozhuk-im]

gitea/modules/cron/tasks_basic.go

Line 22 in 48598a7

NoSuccessNotice: true,

It set in sources, at least for Update Mirrors, and set in config - not help.

[rozhuk-im]

#12438 - not complete

[zeripath]

No #12438 only changes the update mirrors setting. That was it's purpose as it clearly states in its comment.

The rest of the cron settings are not set to NO_SUCCESS= true by default.

If you don't want them set them yourself.

[rozhuk-im]

Sorry, I miss that last release does not include #12438