Skip to content

Lots of zombie Git processes #13987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 6 tasks
Trumeet opened this issue Dec 14, 2020 · 4 comments · Fixed by #14006
Closed
1 of 6 tasks

Lots of zombie Git processes #13987

Trumeet opened this issue Dec 14, 2020 · 4 comments · Fixed by #14006
Labels
Milestone

Comments

@Trumeet
Copy link

Trumeet commented Dec 14, 2020

Description

It's still not clear what is happening, but after I started the website days ago, I found there's a bunch of (currently 263) zombie git processes under gitea (Look at the htop result), and the memory usage is high (not sure if this is intended).

I have some repos in this install, and one of them is a mirror of youtube-dl. I spotted some errors pulling this repo (just found this repo is disabled). I have another install but has lesser visits and does not have mirrors, and there's no such problem.

Screenshots

image

@zeripath
Copy link
Contributor

zeripath commented Dec 14, 2020

Unfortunately I can't look at your log gist on my phone as it is too large however, I will try to look at it tomorrow to attempt to discover if there is a reason for these dangling processes.

On the admin pages there is process subpage that will be able to tell you what those git tasks are supposed to be doing and give you the a button to cancel them (or at least attempt to)

That would be the quickest way to report what was causing these processes.


Hmm thinking on its potentially git processes being cancelled like this that could be the cause, depending on if they don't have their exit code read.

I guess the logs might tell us more

@zeripath
Copy link
Contributor

Ah so it looks like it's related to your broken mirrors.

zeripath added a commit to zeripath/gitea that referenced this issue Dec 15, 2020
After cancelling the context we still need to wait for the
command to finish otherwise zombie processes may occur

Fix go-gitea#13987

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath
Copy link
Contributor

And I think I've worked it out.

@Trumeet
Copy link
Author

Trumeet commented Dec 16, 2020

Ah so it looks like it's related to your broken mirrors.

Thanks. Unfortunately I just rebooted the system so I cannot confirm that, but since I had already updated the link to the mirror, I checked and confirmed that there's no zombie git processes since the last boot.

@noerw noerw added this to the 1.14.0 milestone Dec 16, 2020
@noerw noerw added the type/bug label Dec 16, 2020
6543 added a commit that referenced this issue Dec 17, 2020
After cancelling the context we still need to wait for the
command to finish otherwise zombie processes may occur

Fix #13987

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: 6543 <[email protected]>
zeripath added a commit to zeripath/gitea that referenced this issue Dec 17, 2020
Backport go-gitea#14006

After cancelling the context we still need to wait for the
command to finish otherwise zombie processes may occur

Fix go-gitea#13987

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: 6543 <[email protected]>
6543 pushed a commit that referenced this issue Dec 17, 2020
Backport #14006

After cancelling the context we still need to wait for the
command to finish otherwise zombie processes may occur

Fix #13987
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants