pull requests 500

[ghostman-git]

v1.14.1
MySQL
docker

2021/05/07 16:15:19 ...outers/repo/issue.go:264:issues() [E] GetIssuesLastCommitStatus: object does not exist [id: refs/pull/1604/head, rel_path: ]
2021/05/07 16:15:19 ...s/context/context.go:194:HTML() [E] Render failed: template: repo/issue/list:88:23: executing "repo/issue/list" at <eq .ViewType "all">: error calling eq: incompatible types for comparison

[lunny]

This should be fixed in 1.14

[ghostman-git]

This should be fixed in 1.14

This is also happening now in v1.14.1
What is the temporary solution?

[zeripath]

OK so the second error is appearing on this line:

								<a class="{{if eq .ViewType "all"}}active{{end}} item" href="{{$.Link}}?q={{$.Keyword}}&type=all&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&milestone={{$.MilestoneID}}&assignee={{$.AssigneeID}}">{{.i18n.Tr "repo.issues.filter_type.all_issues"}}</a>

and at the eq .ViewType "all" test - which means most likely that .ViewType is not set.

Now, routers/repo/issue.go:Issues() and in particular the function issues(...) is the place that this should have been set.

Now the only way that happens is if there has been a ServerError call before it - and looking at Issues(...) we see that the call from issues(...) doesn't check if the context is written before attempting to render the template.

So there is at least one bug here that needs a further fix.

---

That means the real issue is:

2021/05/07 16:15:19 ...outers/repo/issue.go:264:issues() [E] GetIssuesLastCommitStatus: object does not exist [id: refs/pull/1604/head, rel_path: ]

[zeripath]

Which is fixed by #15716 and its backport #15715 .

Therefore this issue is fixed and will be in 1.14.2 which is very soon to be released - but I will fix the issue that I've noted above.