Skip to content

[LFS] video player cannot be controlled #16414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marxangels opened this issue Jul 13, 2021 · 3 comments · Fixed by #24592
Closed

[LFS] video player cannot be controlled #16414

marxangels opened this issue Jul 13, 2021 · 3 comments · Fixed by #24592
Labels
type/enhancement An improvement of existing functionality

Comments

@marxangels
Copy link

marxangels commented Jul 13, 2021 •
edited
Loading

The progress bar of the HTML video player cannot be dragged, in other words, the player cannot be controlled to play on the specified position.

To fix this we need support for the Accept-Ranges: bytes HTTP header.
@marxangels marxangels changed the title [Accept-Ranges] The progress bar of HTML video player cannot be dragged [LFS] The progress bar of HTML video player cannot be dragged Jul 13, 2021
@marxangels marxangels changed the title [LFS] The progress bar of HTML video player cannot be dragged [LFS] video player cannot be control Jul 13, 2021
@marxangels marxangels changed the title [LFS] video player cannot be control [LFS] video player cannot be controlled Jul 13, 2021
@noerw noerw added the type/enhancement An improvement of existing functionality label Jul 13, 2021
@stale
Copy link

stale bot commented May 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label May 1, 2022
@wxiaoguang
Copy link
Contributor

Related to

@stale stale bot removed the issue/stale label May 1, 2022
@wxiaoguang wxiaoguang linked a pull request May 1, 2022 that will close this issue
Serve LFS/attachment with http.ServeContent to Support Range-Request #18448
Closed
@wxiaoguang wxiaoguang mentioned this issue Feb 14, 2023
Merged
@wxiaoguang wxiaoguang mentioned this issue May 8, 2023
Merged
@wxiaoguang
Copy link
Contributor

Will be fixed by Make repository response support HTTP range request #24592

lunny pushed a commit that referenced this issue May 9, 2023
@wxiaoguang
Make repository response support HTTP range request (#24592)
023a048 
Replace #20480
Replace #18448

Close #16414
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
3 participants
@wxiaoguang @noerw @marxangels