[API] incorrect permission values of repos if using notifications endpoints #19759
Labels
Comments
Which one? I need an URL. |
|
Just the list endpoint for example |
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
May 19, 2022
The permissions created in convertRepo use a minimal perm.AccessModeRead instead of correctly computing the permission for the repository. This incorrect permission is then reported to the user. I do not believe that reporting the permissions is helpful and therefore I propose we simply null these out. The user can check their permissions using a different endpoint. Fix go-gitea#19759 Signed-off-by: Andrew Thornton <[email protected]>
|
I think reporting the permission here is a mistake and we should not report it. |
6543
pushed a commit
that referenced
this issue
May 20, 2022
The permissions created in convertRepo use a minimal perm.AccessModeRead instead of correctly computing the permission for the repository. This incorrect permission is then reported to the user. I do not believe that reporting the permissions is helpful and therefore I propose we simply null these out. The user can check their permissions using a different endpoint. Fix #19759 Signed-off-by: Andrew Thornton <[email protected]>
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this issue
Aug 24, 2022
…ea#19761) The permissions created in convertRepo use a minimal perm.AccessModeRead instead of correctly computing the permission for the repository. This incorrect permission is then reported to the user. I do not believe that reporting the permissions is helpful and therefore I propose we simply null these out. The user can check their permissions using a different endpoint. Fix go-gitea#19759 Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Requesting a notification endpoint returns wrong values of the permission object.
It always looks like:
{ "admin": false, "push": false, "pull": true }even if I own the repo where it should be
{ "admin": true, "push": true, "pull": true }Gitea Version
1.17.0 (also on try.gitea.io)
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
build from source, from CLI
Database
No response
The text was updated successfully, but these errors were encountered: