You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In general, href="javascript:;" is an anti-pattern (see http://www.jibbering.com/faq/#javascriptURI for the original intent).
As a rule of thumb, links go somewhere and buttons are used to resolve actions.
is the only occurence I could find so far. Since it is controlled by JavaScript alone, a fix would require the <a> to become <button type="button"> (or perhaps a submit button if there would be a <form> and Go-side logic to update the saved topics).
Plus some style changes to make it look like before.
Gitea Version
1.17.0+dev-675-g81cf00686
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
try.gitea.io
Database
No response
The text was updated successfully, but these errors were encountered:
Description
I noticed this while working on #19900.
In general,
href="javascript:;"
is an anti-pattern (see http://www.jibbering.com/faq/#javascriptURI for the original intent).As a rule of thumb, links go somewhere and buttons are used to resolve actions.
gitea/templates/repo/home.tmpl
Lines 48 to 49 in d9b50e4
is the only occurence I could find so far. Since it is controlled by JavaScript alone, a fix would require the
<a>
to become<button type="button">
(or perhaps a submit button if there would be a<form>
and Go-side logic to update the saved topics).Plus some style changes to make it look like before.
Gitea Version
1.17.0+dev-675-g81cf00686
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
try.gitea.io
Database
No response
The text was updated successfully, but these errors were encountered: