Skip to content

Delete Branch After Merge does not happen when using the "auto-merge when checks succeed" feature #20632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
parnic opened this issue Aug 2, 2022 · 8 comments
Closed

Delete Branch After Merge does not happen when using the "auto-merge when checks succeed" feature #20632

parnic opened this issue Aug 2, 2022 · 8 comments
Labels
type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.24.0

Comments

@parnic
Copy link
Contributor

parnic commented Aug 2, 2022 •
edited
Loading

Description

Using the "auto-merge when checks succeed" option does not delete the branch once the merge goes through. I would expect that if the repo has configured "delete branch by default" that it would happen on the auto-merge as well.

Gitea Version

1.17.0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

Git Version

2.37.1

Operating System

Ubuntu

How are you running Gitea?

Downloaded from Github releases page.

Database

PostgreSQL
@parnic parnic added the type/bug label Aug 2, 2022
@parnic parnic changed the title Delete Branch After Merge checkbox is gone in 1.17.0+ Delete Branch After Merge checkbox is gone, and feature does not work, in 1.17.0+ Aug 2, 2022
@parnic parnic changed the title Delete Branch After Merge checkbox is gone, and feature does not work, in 1.17.0+ Delete Branch After Merge does not happen when using the "auto-merge when checks succeed" feature Aug 2, 2022
@wxiaoguang
Copy link
Contributor

That's just not been implemented yet 😂 no enough time to implement it at that time.

So I think this issue is more likely to be a feature request or an enhancement for it.

Some missing features in my mind:

  • Show the already scheduled auto merge style.
  • Support "delete branch after merge" in the auto merge.

@HenkVanMaanen
Copy link

Same problem here

@lunny lunny added type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first. and removed type/bug labels May 7, 2024
@lunny
Copy link
Member

lunny commented May 7, 2024

I also think this is an enhancement needs to be implemented. It needs some changes.

  • Add a checkbox like manually merge near the auto merge button.
  • Delete the branch when auto merge succeed.
  • Notification users when auto merge succeed but delete branch failed.

@makar112233
Copy link

makar112233 commented Jun 26, 2024 •
edited
Loading

+1 for this feature

@evgenyvalavin
Copy link

+1

2 similar comments
@mccamicha
Copy link

+1

@gha88
Copy link

gha88 commented Feb 6, 2025

+1

@lunny
Copy link
Member

lunny commented Feb 6, 2025

This has been resolved by #32343

@lunny lunny closed this as completed Feb 6, 2025
@lunny lunny added this to the 1.24.0 milestone Feb 6, 2025
@go-gitea go-gitea locked as resolved and limited conversation to collaborators May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.24.0
Development

No branches or pull requests
8 participants
@lunny @parnic @wxiaoguang @evgenyvalavin @HenkVanMaanen @gha88 @mccamicha @makar112233