After downloading a repository with LFS files as an archive, unnecessary git-hooks created and as a result trying to create a PR results in an error 500

[dav-sea]

Description

After downloading a repository with LFS files as an archive, unnecessary git-hooks created and as a result trying to create a PR results in an error 500

Steps for representation:

1. Import or clone this repo
2. Download the repository as an archive via the Web UI
3. Create a PR with any modified lfs file
4. Close the PR and then create a new one just like it
5. Get error 500 and broken PR

git lfs env

git-lfs/3.0.2 (GitHub; windows amd64; go 1.17.2)
git version 2.35.1.windows.2

Logs

2022/09/12 14:35:04 ...ervices/pull/pull.go:477:pushToBaseRepoHelper() [E] [631f1967-13] Unable to push PR head for sergey-cs/representation-for-bug-with-download-archive#4 (89:sergey-cs/representation-for-bug-with-download-archive:refs/pull/4/head) due to Error: exit status 1 - batch request: missing protocol: ""
        error: failed to push some refs to 'HIDDEN\\sergey-cs\representation-for-bug-with-download-archive.git'

        /source/services/pull/pull.go:477 (0x1c099ee)
        /source/services/pull/pull.go:426 (0x1c050f2)
        /source/services/pull/pull.go:71 (0x1c050f3)
        /source/routers/web/repo/pull.go:1220 (0x21a05d2)
        /source/modules/web/wrap_convert.go:47 (0x1fae9f6)
        /source/modules/web/wrap.go:41 (0x1facc29)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x1792bf5)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/modules/web/wrap.go:63 (0x1fad0af)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/modules/web/wrap.go:63 (0x1fad0af)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/modules/web/wrap.go:63 (0x1fad0af)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/middleware/get_head.go:37 (0x2014ea4)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/modules/web/wrap.go:63 (0x1fad0af)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/modules/context/context.go:802 (0x1b7989a)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:71 (0x1790a2c)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:314 (0x17923db)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x1792bf5)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/routers/web/base.go:174 (0x21e3151)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/gitea.com/go-chi/session@v0.0.0-20211218221615-e3605d8b28b8/session.go:257 (0x1584ddd)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/modules/web/wrap.go:110 (0x1fadb48)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:71 (0x1790a2c)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:314 (0x17923db)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x1792bf5)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/routers/common/middleware.go:79 (0x201a4a2)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/modules/web/routing/logger_manager.go:123 (0x1fa894f)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/middleware/strip.go:30 (0x2017c18)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/chi-middleware/proxy@v1.1.1/middleware.go:37 (0x201451e)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/routers/common/middleware.go:32 (0x201a2f2)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:88 (0x17909e1)
        /source/modules/web/route.go:200 (0x1fac06d)
        /usr/local/go/src/net/http/server.go:2916 (0x8914da)
        /usr/local/go/src/net/http/server.go:1966 (0x88c996)
        /usr/local/go/src/runtime/asm_amd64.s:1571 (0x3adf80)


2022/09/12 14:35:04 ...ers/web/repo/pull.go:1244:CompareAndPullRequestPost() [E] NewPullRequest: Push: sergey-cs/representation-for-bug-with-download-archive:branch-with-changed-lfs-file sergey-cs/representation-for-bug-with-download-archive:refs/pull/4/head exit status 1 - batch request: missing protocol: ""
        error: failed to push some refs to 'HIDDEN\sergey-cs\representation-for-bug-with-download-archive.git'

        /source/routers/web/repo/pull.go:1244 (0x21a09b3)
        /source/modules/web/wrap_convert.go:47 (0x1fae9f6)
        /source/modules/web/wrap.go:41 (0x1facc29)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x1792bf5)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/modules/web/wrap.go:63 (0x1fad0af)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/modules/web/wrap.go:63 (0x1fad0af)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/modules/web/wrap.go:63 (0x1fad0af)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/middleware/get_head.go:37 (0x2014ea4)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/modules/web/wrap.go:63 (0x1fad0af)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/modules/context/context.go:802 (0x1b7989a)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:71 (0x1790a2c)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:314 (0x17923db)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x1792bf5)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/routers/web/base.go:174 (0x21e3151)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/gitea.com/go-chi/session@v0.0.0-20211218221615-e3605d8b28b8/session.go:257 (0x1584ddd)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/modules/web/wrap.go:110 (0x1fadb48)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:71 (0x1790a2c)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:314 (0x17923db)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:442 (0x1792bf5)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/routers/common/middleware.go:79 (0x201a4a2)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/modules/web/routing/logger_manager.go:123 (0x1fa894f)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/middleware/strip.go:30 (0x2017c18)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/chi-middleware/proxy@v1.1.1/middleware.go:37 (0x201451e)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /source/routers/common/middleware.go:32 (0x201a2f2)
        /usr/local/go/src/net/http/server.go:2084 (0x88deee)
        /go/pkg/mod/github.com/go-chi/chi/v5@v5.0.7/mux.go:88 (0x17909e1)
        /source/modules/web/route.go:200 (0x1fac06d)
        /usr/local/go/src/net/http/server.go:2916 (0x8914da)
        /usr/local/go/src/net/http/server.go:1966 (0x88c996)
        /usr/local/go/src/runtime/asm_amd64.s:1571 (0x3adf80)

Workaround

At the moment of downloading the archive via Web UI, unnecessary hooks created in the git folder. If you remove them, the problem will be fixed

Also, to prevent the same problem, repeatedly disable the ability to download the repository as an archive from the web ui using config the repository.DISABLE_DOWNLOAD_SOURCE_ARCHIVES=true

The problem also persists in 1.17.2

Gitea Version

1.17.1

Can you reproduce the bug on the Gitea demo site?

No

[philip-peterson]

I believe this is the same as #19810 . I have a plan to fix, posted as a comment on that issue today.

[philip-peterson]

I actually can't reproduce it on vanilla Gitea, but here's a branch, maybe someone can see if it fixes it for them. https://github.com/go-gitea/gitea/compare/main...philip-peterson:gitea:peterson/poc-archive-patch?expand=1

[dav-sea]

@philip-peterson, Are you moving LFS files to the gitea repository?

After downloading the archive do you get unnecessary git-hooks?

Update: The problem occurs only after closing the PR and creating a new one exactly the same. Specified it in the steps for reproduction here.