You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@lunny but autoclose commit would then need to also close the other issue. To not make it too complicated, i would propose to not close the issue if it has another one depending on it.
So, if i committed something to #1 to autoclose #1, but #1 depends on #2 and #2 is still open, it would simply not close #1. Maybe a logmessage to the issue why it couldn't be closed.
@lunny@kolaente There are two options either as @kolaente described not to close issue even if in commit with fixed #1 message or not allow pushing commits for issues that can not be closed yet
@lunny@bkcsoft I'd say one issue should be able to have more than one dependent issue. (And all dependents must be closed)
Example: #1 depends on #2, #3 and #4, so #2, #3 and #4 must be closed before #1 can be closed.
Activity
lunny commentedon Jul 23, 2017
A good idea.
bkcsoft commentedon Jul 26, 2017
As long as it only checks one jump. e.g. #1 => #2 => #3. #1 only checks #2 and #2 only checks #3.
Otherwise the lookup-time would be painful...
lafriks commentedon Jul 26, 2017
And what about autoclose with commit? Should than pre-receive hook fail?
lunny commentedon Jul 26, 2017
@bkcsoft So that one issue only dependent only 1 issue?
@lafriks
autoclose with commitwill then check the dependecieskolaente commentedon Jul 27, 2017
@lunny but autoclose commit would then need to also close the other issue. To not make it too complicated, i would propose to not close the issue if it has another one depending on it.
So, if i committed something to #1 to autoclose #1, but #1 depends on #2 and #2 is still open, it would simply not close #1. Maybe a logmessage to the issue why it couldn't be closed.
lafriks commentedon Jul 27, 2017
@lunny @kolaente There are two options either as @kolaente described not to close issue even if in commit with
fixed #1message or not allow pushing commits for issues that can not be closed yetbkcsoft commentedon Aug 8, 2017
@lunny So that one issue only depends on the closest issues
lunny commentedon Aug 8, 2017
@bkcsoft I mean one issue maybe dependent two or three issues?
kolaente commentedon Aug 8, 2017
@lunny @bkcsoft I'd say one issue should be able to have more than one dependent issue. (And all dependents must be closed)
Example:
#1 depends on #2, #3 and #4, so #2, #3 and #4 must be closed before #1 can be closed.
lunny commentedon Aug 9, 2017
@kolaente not only issues, but also pull requests.
bkcsoft commentedon Aug 9, 2017
@lunny @kolaente Never said anything about multiple dependencies, only that an issue should only be linked to it's closest related dependency.
kolaente commentedon Aug 9, 2017
I'll start working on this (But bare with me, my go skills are not the best 😁 )
Added dependencies for issues (#2196) (#2531)
techknowlogick commentedon Jul 18, 2018
Closing as PR has been merged.
Merge tag 'v1.6.0-rc1'