Skip to content

Unfold/Unview all files #23628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gempir opened this issue Mar 22, 2023 · 1 comment · Fixed by #23639
Closed

Unfold/Unview all files #23628

gempir opened this issue Mar 22, 2023 · 1 comment · Fixed by #23639
Assignees
@sillyguodong
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@gempir
Copy link
Contributor

gempir commented Mar 22, 2023

Feature Description

I find myself coming back to PRs a lot, or after a code review of a Colleague I need to look at my own PR and when I want to review old files it's annoying to unclick "viewed" one-by-one.

I think there are multiple options of achieving this, I'm unsure which is the best approach.

  1. A button that marks all files as unviewed (maybe it can also do mark as viewed for double utility)
  2. Just have a button expand/fold all files and leaving the viewed status alone
  3. Reset the view status after a PR merge (this only helps in some cases, and might just be confusing, so worst option IMO)
  4. ???

I don't see any way that GitHub solves this. I think you also need to manually unfold files there.
Maybe there is a better solution I'm not seeing yet?

Screenshots

No response
@gempir gempir added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Mar 22, 2023
@sillyguodong
Copy link
Contributor

I will try to implement it with your first option

@sillyguodong sillyguodong self-assigned this Mar 22, 2023
@sillyguodong sillyguodong mentioned this issue Mar 22, 2023
Merged
lunny pushed a commit that referenced this issue Apr 9, 2023
@sillyguodong @silverwind
Expand/Collapse all changed files (#23639)
bedad23 
close #23628 

Now in `...` dropdown, you can expand or collapse all diff files that
have loaded.

https://user-images.githubusercontent.com/33891828/227749688-2d406916-3347-49f6-93a5-4092a00e8809.mov

Co-authored-by: silverwind <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sillyguodong sillyguodong

Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expand/Collapse all changed files sillyguodong/gitea
2 participants
@gempir @sillyguodong