Incorrect line number display of process logs in actions

[yp05327]

Description

https://gitea.com/yp05327/testrepo/actions/runs/14

Gitea Version

1.20.0+dev-251-g9f39def99

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

gitea.com

Database

None

[yp05327]

It seems that the process state icon's location is also strange.

[wxiaoguang]

The line number is correct. However, some CLI programs use "\r" to print new content in current line.

So, the strings in "line 1" are actually from \rReading...1%\rReading...5%\rReading...100%\n

Two approaches to make it better:

1. Treat all "\r" as "\n"
2. Gitea assembles the content, only renders the last "Reading...100%\n".

Personally, I dislike 1, prefer 2. Because, approach 1 would render a lot of non-sense "progress" information.

Approach 2 renders what end users would see in the end.

A demo program:

#include <stdio.h>
#include <unistd.h>

int main()
{
    printf("testing ...\n");
    for (int i = 0; i < 10; i++) {
        printf("\r%d", i);
        fflush(stdout);
        sleep(1);
    }
    return 0;
}

[wxiaoguang]

I guess #23820 could help (I haven't tried). Could you take a look? Thank you.

[silverwind]

Gitea assembles the content, only renders the last "Reading...100%\n".

Also prefer this if line deletions can be reliably detected and removed, e.g. just render it like a terminal would after modifications are completed on the line.

[silverwind]

It seems that the process state icon's location is also strange.

I think #23789 has fixed that alignment.

[yp05327]

I think #23789 has fixed that alignment.

Yes, it fixed in #23789

[wxiaoguang]

Wait, keep it open.

The key problem (line number) hasn't been fixed. #23789 only improves some alignments.