Skip to content

[doc] ./gitea dump doesn't allows to specify backup destination #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vizcay opened this issue Aug 30, 2017 · 19 comments
Closed

[doc] ./gitea dump doesn't allows to specify backup destination #2436

vizcay opened this issue Aug 30, 2017 · 19 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/docs This PR mainly updates/creates documentation

Comments

@vizcay
Copy link

vizcay commented Aug 30, 2017

I like gitea dump because it allows to backup everything into a single file, but I find it difficult to automate (weekly cron job) because it's doesn't allows to specify the exact destination of the backup (to copy it elsewhere for example).

That leaves us with the (not pretty) option to parse the output to get the zip name.. something like gitea dump --destination /path/to/zip would be great.

Sorry not a go developer, if not I will simply send a PR for this (yeps it's a lame excuse, I know =)

@vizcay
Copy link
Author

vizcay commented Aug 31, 2017

./gitea dump 2>&1 >/dev/null | awk 'END {print $NF}'
(just in case somebody wonders how to get it)

@lafriks lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Aug 31, 2017
@lafriks lafriks added this to the 1.x.x milestone Aug 31, 2017
@lafriks
Copy link
Member

lafriks commented Aug 31, 2017

I think WIP PR #1637 will implement this?

@vizcay
Copy link
Author

vizcay commented Aug 31, 2017

@lafriks Not exactly:

   --config FILE, -c FILE   Custom configuration FILE path (default: "custom/conf/app.ini")
   --tempdir PATH, -t PATH  Temporary directory PATH (default: "/tmp")
   --target PATH            Target directory PATH to save backup archive (default: "./")
   --verbose, -v            Show process details
   --db                     Backup the database (default: true)
   --repos                  Backup repositories (default: true)
   --data                   Backup attachments and avatars (default: true)
   --custom                 Backup custom files (default: true)

--target will allow to specify where to land the zip, but still no luck to set the filename.

@bkcsoft
Copy link
Member

bkcsoft commented Sep 4, 2017

Should be easy enough to change --target to take a filename instead of a directory :)

@jabouchleih
Copy link

jabouchleih commented Feb 13, 2018

Was this functionality removed?

OPTIONS:
--config value, -c value Custom configuration file path (default: "custom/conf/app.ini")
--verbose, -v Show process details
--tempdir value, -t value Temporary dir path (default: "/tmp")
--database value, -d value Specify the database SQL syntax

@vizcay
Copy link
Author

vizcay commented Feb 14, 2018

@Quinity to be honest IDK, I ended using awk to extract the dump filename but a --target or something similar will be much more appreciated.

@The-King-of-Toasters
Copy link

I recently tried tackling this using cron on my debian machine, but I had no luck. However, I found great sucess using a systemd service/timer and setting the WorkingDirectory to wherever you like.

The service file:

[Unit]
Description=Gitea Dump

[Service]
Type=simple
User=git
Group=git
WorkingDirectory=/var/gitea/backup
ExecStart=/usr/local/bin/gitea dump -c /etc/gitea/app.ini
Environment=USER=git HOME=/home/git GITEA_WORK_DIR=/var/lib/gitea

[Install]
WantedBy=multi-user.target

Timer:

[Unit]
Description=Daily Gitea Dump

[Timer]
# See systemd.time(7) for time format
OnCalendar=*-*-* 05:00:00
Persistent=true

[Install]
WantedBy=timers.target

And the output of /var/gitea/backup:

$ ls /var/gitea/backup
gitea-dump-1529562686.zip

@stale
Copy link

stale bot commented Jan 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 22, 2019
@techknowlogick techknowlogick added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Jan 31, 2019
@nodiscc
Copy link
Contributor

nodiscc commented Nov 20, 2019

--target is not documented in https://docs.gitea.io/en-us/backup-and-restore/

@lunny lunny added type/docs This PR mainly updates/creates documentation and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Nov 21, 2019
@lunny lunny removed this from the 1.x.x milestone Nov 21, 2019
@lunny
Copy link
Member

lunny commented Nov 21, 2019

So this is a documentation problem not a feature.

@lunny lunny changed the title ./gitea dump doesn't allows to specify backup destination [doc] ./gitea dump doesn't allows to specify backup destination Nov 21, 2019
@AllTaken
Copy link

I don't know. Does --target allow you to specify the filename now? That was the original feature request as I understand it. At least that's what I would want for my use-case.

@nodiscc
Copy link
Contributor

nodiscc commented Nov 26, 2019

@lunny I was just mentioning the missing documentation, in addition to the feature request discussed here - I think it's a good opportunity to fix the documentation. I don't think --target accepts a destination filename (only a directory).

I would appreciate this change, because I run dumps from a cron job and the destination directory ends up cluttered with daily dumps.

But maybe some people prefer the old behavior - in this case there could be 2 separate options (--destdir --destfile), or we could just resort to --destfile /var/backups/gitea/gitea-dump-$(date +%s)

@AllTaken
Copy link

So it looks like this has been implemented with:
--file name, -f name: Name of the dump file with will be created. Optional. (default: gitea-dump-[timestamp].zip).

I guess you can close this issue?
And to anyone else using the AWK trick from above: that doesn't work anymore.

@julian-poidevin
Copy link

--target is not documented in https://docs.gitea.io/en-us/backup-and-restore/

This is not yet documented

@nodiscc
Copy link
Contributor

nodiscc commented Jun 1, 2020

--work-dir is also not documented (#9100)

@6543
Copy link
Member

6543 commented Sep 7, 2020

it's implemented option: --file/-f

@6543 6543 closed this as completed Sep 7, 2020
@6543
Copy link
Member

6543 commented Sep 7, 2020

and if you type gitea dump --help you get the whole documentation of this subcomand

@nodiscc
Copy link
Contributor

nodiscc commented Sep 12, 2020

@6543 yes but the documentation is wrong https://docs.gitea.io/en-us/command-line/#dump

Just copy pasting the gitea dump --help output there would be better than having outdated documentation. Do you want me to send a pull request?

@6543
Copy link
Member

6543 commented Sep 12, 2020

@nodiscc yes would be great!!!

files are in https://github.com/go-gitea/gitea/tree/master/docs

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

No branches or pull requests