Skip to content

Makefile invokes find with nonportable, non-POSIX -not option #24564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
riastradh opened this issue May 6, 2023 · 0 comments · Fixed by #24565
Closed

Makefile invokes find with nonportable, non-POSIX -not option #24564

riastradh opened this issue May 6, 2023 · 0 comments · Fixed by #24565
Labels
type/bug

Comments

@riastradh
Copy link
Contributor

Description

The Makefile runs find ... -not ... to derive GO_SOURCES:

GO_SOURCES += $(shell find $(GO_DIRS) -type f -name "*.go" -not -path modules/options/bindata.go -not -path modules/public/bindata.go -not -path modules/templates/bindata.go)

On some platforms such as NetBSD, the -not option is not supported. The portable and standard POSIX way to do this is with with !: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/find.html

Gitea Version

ef92459

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

make

Database

None
riastradh pushed a commit to riastradh/gitea that referenced this issue May 6, 2023
Makefile: Use portable !', not GNUish -not', with find(1).
9911098 
fix go-gitea#24564
@riastradh riastradh mentioned this issue May 6, 2023
Merged
lunny pushed a commit that referenced this issue May 7, 2023
@riastradh
Makefile: Use portable !, not GNUish -not, with find(1). (#24565)
377e013 
fix #24564

Co-authored-by: Taylor R Campbell <[email protected]>
@GiteaBot GiteaBot mentioned this issue May 7, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue May 7, 2023
@riastradh @GiteaBot
Makefile: Use portable !, not GNUish -not, with find(1). (go-gitea#24565
4a81183 
)

fix go-gitea#24564

Co-authored-by: Taylor R Campbell <[email protected]>
lunny pushed a commit that referenced this issue May 7, 2023
@GiteaBot
Makefile: Use portable !, not GNUish -not, with find(1). (#24565) (#2…
6f57be0 
…4572)

Backport #24565 by @riastradh

fix #24564

Co-authored-by: Taylor R Campbell <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Makefile: Use portable !, not GNUish -not, with find(1). riastradh/gitea
1 participant
@riastradh