Skip to content

LDAP group map multiline support #24826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
codefritzel opened this issue May 20, 2023 · 1 comment · Fixed by #25043
Closed

LDAP group map multiline support #24826

codefritzel opened this issue May 20, 2023 · 1 comment · Fixed by #25043
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@codefritzel
Copy link

codefritzel commented May 20, 2023 •
edited
Loading

Feature Description

With more than one group mapping, the single-line text field can quickly become very confusing. How about replacing the input text field with a multiline textarea?

This would make it easier to deal with many LDAP groups.

Screenshots

text input (actual)
input_text

textarea (idea)
textarea
@codefritzel codefritzel added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels May 20, 2023
@wxiaoguang wxiaoguang mentioned this issue Jun 2, 2023
Merged
@wxiaoguang
Copy link
Contributor

-> Minor UI improvements: logo alignment, auth map editor, auth name display #25043

lunny pushed a commit that referenced this issue Jun 2, 2023
@wxiaoguang
Minor UI improvements: logo alignment, auth map editor, auth name dis…
e389714 
…play (#25043)

Some minor UI improvements together (then no need to review 3 small PRs)

# The Map for auth sources

Close #24826

Now the LDAP and OAuth2 both have multiple line editor for the map (and
it can be resized by the handler)

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/7eed1618-0d71-4df2-84bd-ca20a06c02db)


![image](https://github.com/go-gitea/gitea/assets/2114189/a94dc6dc-0e3b-4185-bac1-8d16561b8e62)

</details>


# The account link display

Before, the UI is misaligned

This PR fixes the misalignment, remove "float right", and show the auth
source name and auth type (in the tooltip).

And the "active" color is changed from dark red to primary color.

Before:

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/3bb4a8f2-2f66-4d62-ac96-096f14aeb819)

</details>

After:

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/05ca46ae-7769-422d-a52a-b7402679cd05)

</details>

# The UI logo alignment

Changed file: `css/base.css`.

Before, there were some "fine tunes", these "fine tunes" only causes
misalignment.

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/395b03c2-6e8c-4742-abf9-8d548dab908d)

</details>

After this PR:

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/3339acdc-7391-45bc-b6ec-a5b3bc7830a6)


![image](https://github.com/go-gitea/gitea/assets/2114189/656a7bee-cdfb-4232-aee9-25b76cae8e00)

</details>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor UI improvements: logo alignment, auth map editor, auth name display wxiaoguang/gitea
2 participants
@wxiaoguang @codefritzel