Skip to content

Translation problem in PL, string placeholder missing #25238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fnetX opened this issue Jun 13, 2023 · 3 comments
Closed

Translation problem in PL, string placeholder missing #25238

fnetX opened this issue Jun 13, 2023 · 3 comments
Labels

Comments

@fnetX
Copy link
Contributor

fnetX commented Jun 13, 2023

Description

The polish translation results in broken template text.

Strings like

activate_account.text_1=Cześć <b>%[1]s</b>, dziękujemy za rejestrację na %[2]!

are broken and result in emails like this user reported: https://mastodon.social/@djvdq/110538301215880465

%[2] needs to become %[2]s.

I'd fix this in the translation source, but it's another proprietary platform I do not want to use.

I propose to add some sort of QA to spot such mistakes. I'm only familiar with Weblate so far, and I think they detect if placeholders in the source string are not present in the translated version, but I'm not sure if it works for every format.

Gitea Version

1.19

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Not relevant

Database

None

@fnetX fnetX added the type/bug label Jun 13, 2023
@delvh
Copy link
Member

delvh commented Jun 13, 2023

Have just fixed that string, is there any other string with broken placeholders?

@delvh delvh closed this as completed Jun 13, 2023
@fnetX
Copy link
Contributor Author

fnetX commented Jun 15, 2023

It is a large problem. I found a double-digit number of occurences. I'll filter through them and report back.

@lunny
Copy link
Member

lunny commented Jul 3, 2023

@lunny lunny closed this as completed Jul 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants