Skip to content

Review bar and "sticky" file header layout regression #26730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wxiaoguang opened this issue Aug 25, 2023 · 2 comments · Fixed by #27322
Closed

Review bar and "sticky" file header layout regression #26730

wxiaoguang opened this issue Aug 25, 2023 · 2 comments · Fixed by #27322
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Aug 25, 2023 •
edited
Loading

Due to #26711 (and other old PRs) , now the "sticky" file header doesn't work well with uncertain review bar height.

Before, the sticky top was hard-coded to 2 magic numbers, but the "review bar" has been changed many times and it uses "flex" layout, the height is not predictable.
@wxiaoguang wxiaoguang added type/bug topic/ui Change the appearance of the Gitea UI labels Aug 25, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Aug 25, 2023
@silverwind
Copy link
Member

Height needs to be predictable for sticky to work, unless there is another solution but I'm not aware of.

@wxiaoguang
Copy link
Contributor Author

I am not working on it either, just open an issue for record.

@wxiaoguang wxiaoguang removed this from the 1.21.0 milestone Sep 20, 2023
This was referenced Sep 28, 2023
Merged
Merged
lunny pushed a commit that referenced this issue Sep 28, 2023
@wxiaoguang
Fix review UI (#27322)
1f00bc4 
Close #26730


1. The `diff-detail-box` was abused, it shouldn't be used for
"DiffFileList/DiffFileTree".
2. Fix the sticky position for various screens.



![image](https://github.com/go-gitea/gitea/assets/2114189/558a5c06-c94c-4e5c-8395-d38473dd21c2)


![image](https://github.com/go-gitea/gitea/assets/2114189/3390fb0e-7dc7-457f-bd0c-398fdb6d24c0)


![image](https://github.com/go-gitea/gitea/assets/2114189/d19dd350-aecf-4909-8ef9-73b09d94560e)
@GiteaBot GiteaBot mentioned this issue Sep 28, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Sep 28, 2023
@wxiaoguang @GiteaBot
Fix review UI (go-gitea#27322)
3510876 
Close go-gitea#26730


1. The `diff-detail-box` was abused, it shouldn't be used for
"DiffFileList/DiffFileTree".
2. Fix the sticky position for various screens.



![image](https://github.com/go-gitea/gitea/assets/2114189/558a5c06-c94c-4e5c-8395-d38473dd21c2)


![image](https://github.com/go-gitea/gitea/assets/2114189/3390fb0e-7dc7-457f-bd0c-398fdb6d24c0)


![image](https://github.com/go-gitea/gitea/assets/2114189/d19dd350-aecf-4909-8ef9-73b09d94560e)
lunny pushed a commit that referenced this issue Sep 28, 2023
@GiteaBot @wxiaoguang
Fix review UI (#27322) (#27331)
e719bf8 
Backport #27322 by @wxiaoguang

Close #26730


1. The `diff-detail-box` was abused, it shouldn't be used for
"DiffFileList/DiffFileTree".
2. Fix the sticky position for various screens.



![image](https://github.com/go-gitea/gitea/assets/2114189/558a5c06-c94c-4e5c-8395-d38473dd21c2)


![image](https://github.com/go-gitea/gitea/assets/2114189/3390fb0e-7dc7-457f-bd0c-398fdb6d24c0)


![image](https://github.com/go-gitea/gitea/assets/2114189/d19dd350-aecf-4909-8ef9-73b09d94560e)

Co-authored-by: wxiaoguang <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix review UI wxiaoguang/gitea
2 participants
@silverwind @wxiaoguang